Do not lookup release from package cloud if fork in circle config.yml #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if package cloud token is not set use hard coded value of 1
arm4b
reviewed
May 12, 2020
arm4b
reviewed
May 12, 2020
add comment about fork that was useful in finding the bug. Co-authored-by: Eugen C. <[email protected]>
guzzijones
changed the title
|
Looks like it passed. |
arm4b
approved these changes
May 12, 2020
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if package cloud token is not set use hard coded value of 1
fixes #752
PR from forks are not able to be run through unit testing. This is because the package cloud token is not set. Here we are not going to lookup the release number in package cloud if it is a fork.
This was stolen from https://github.com/StackStorm/st2-packages/blob/29a493e33de928e6df452a9102e80aaeadc5ec53/.circle/buildenv_st2.sh#L45-L51